Favorites Pony December 26, 2006 5:47 PM Subscribe
Pony: After favoriting something, the link on the thread still says "add to favorites" (and for comments, it remains a "+"). Suggest changing to "remove from favorites" (and for comments, a "-"). Accidentally favoriting something requires going to the favorites page to undo it, when it could be a lot easier.
yep, I need to revamp the caching on that. 5-10 minutes after you hit it, the link will update appropriately.
posted by mathowie (staff) at 6:22 PM on December 26, 2006
posted by mathowie (staff) at 6:22 PM on December 26, 2006
Matt, does it update to allow you to un-favourite a comment from the thread view? I don't remember seeing this.
At the moment, if you click the plus after favouriting something, it tells you that 'you have already favourited this comment'.
It'd be great if you had the option to un-favourite the comment there and then.
This seems like it would be a better solution than changing the plus links on comments to minuses in the thread, which I guess would require either a nasty JOIN, or in the comment loop checking if the comment ID is in an array of all the user's favourited comments.
Also, GreaseMonkey is great for solving this kind of problem.
posted by matthewr at 6:39 PM on December 26, 2006
At the moment, if you click the plus after favouriting something, it tells you that 'you have already favourited this comment'.
It'd be great if you had the option to un-favourite the comment there and then.
This seems like it would be a better solution than changing the plus links on comments to minuses in the thread, which I guess would require either a nasty JOIN, or in the comment loop checking if the comment ID is in an array of all the user's favourited comments.
Also, GreaseMonkey is great for solving this kind of problem.
posted by matthewr at 6:39 PM on December 26, 2006
yep, I need to revamp the caching on that. 5-10 minutes after you hit it, the link will update appropriately.
I'm not seeing this behavior at all. When I go to any of my old favorites, I still see "+ add to favorites" or "+" (for comments).
posted by knave at 7:09 PM on December 26, 2006
I'm not seeing this behavior at all. When I go to any of my old favorites, I still see "+ add to favorites" or "+" (for comments).
posted by knave at 7:09 PM on December 26, 2006
Me neither, with FF or IE on XP.
For example, I marked this thread as a favorite a couple of days ago, but I still see [+ add to favorites] in the top posted by line.
I assumed this wasn't intended behaviour, but was something that'd get revisited later. Should it be changing to [- remove from favorites] ?
posted by stavrosthewonderchicken at 8:53 PM on December 26, 2006
For example, I marked this thread as a favorite a couple of days ago, but I still see [+ add to favorites] in the top posted by line.
I assumed this wasn't intended behaviour, but was something that'd get revisited later. Should it be changing to [- remove from favorites] ?
posted by stavrosthewonderchicken at 8:53 PM on December 26, 2006
(I've checked, and both blue and green have similar behaviours for me, at least when marking threads themselves as faves.)
posted by stavrosthewonderchicken at 8:55 PM on December 26, 2006
posted by stavrosthewonderchicken at 8:55 PM on December 26, 2006
You are not logged in, either login or create an account to post comments
posted by knave at 5:47 PM on December 26, 2006